symfony / flex

Composer plugin for Symfony
MIT License
4.15k stars 181 forks source link

Add-lines patcher can not be converted from .yaml to .php #984

Open alexander-schranz opened 1 year ago

alexander-schranz commented 1 year ago

Stumbled over that add-lines implemented in https://github.com/symfony/flex/pull/975 is now used not only for phpunit.xml.dist files or .js, ... files but also for config recipes files.

Sadly used for config/packages/.. or config/routes/.. I personally would avoid using that and have another mechanism there.

Maybe merged .yaml or even own notifier_...yaml would be better there.

This kind of configurations can currently this way not be converted to PHP based recipes. And I don't see a way for do it, without somebody need todo this manually for every recipe.

This recipe patches will so fail on PHP based config recipes repo currently: https://github.com/schranz-php-recipes/symfony-recipes-php/pull/44/files#