symfony / flex

Composer plugin for Symfony
MIT License
4.15k stars 181 forks source link

[AddLines] Fix update process to send changes to RecipeUpdate vs make them immediately #988

Closed weaverryan closed 1 year ago

weaverryan commented 1 year ago

Hi!

This was an oversight when I create AddLinesConfigurator.

During recipes:update, the purpose of the update() method in each configurator is to record what the "original" contents of a file would look like from the original recipe & what the "new" contents of a file would look like with the new recipe. Then, LATER, the patcher system creates a diff from these.

The AddLinesConfigurator was going rogue and updating the files immediately, which caused the "patcher" system later to explode because this file was unexpectedly already modified.

The changes are less drastic than they look, as code needed to be moved from some public methods -> private methods.

Cheers!

fabpot commented 1 year ago

Thank you @weaverryan.