Add support for new handlers

Seldaek commented 12 years ago

Missing handlers:

[x] mongodb
[ ] couchdb / doctrinecouchdb
[x] elasticsearch / elastica
[ ] dynamodb
[x] syslogd
[x] loggly
[x] browserconsole (might need to be made the default in the standard edition if it works well)
[x] filter
[x] flowdock
[x] rollbar
[x] whatfailuregroup
[ ] mandrill
[x] slack
[ ] fleephook
[x] sampling

wheelsandcogs commented 12 years ago

It looks like ChromePHP and Gelf support are now included, so I'd like to add support for the MongoDB handler, but I'm not sure of the best approach. Following the existing handler config would give something like:

<?php
// ..... snip ....

case 'mongodb':
    $definition->setArguments(array(
        new \Mongo($handler['host']),
        $handler['database'],
        $handler['collection'],
        $handler['level'],
        $handler['bubble'],
    ));
    break;

and allow a config like:

monolog:
    handlers:
        main:
            type:  stream
            path:  %kernel.logs_dir%/%kernel.environment%.log
            level: debug
        mongo:
            type: mongodb
            host: mongodb://localhost:27017
            database: logs
            collection: prod
            level: debug
            bubble: true

Creating the Mongo instance there is clearly not the correct way to do it, but I don't know the Service or DI layers well enough to know how to inject it correctly? Also, if I'm using Doctrine MongoDB ODM, it would be nice to be able to reuse the connection thats already been configured for that so that I don't have to maintain two separate configs.

Any ideas?

Seldaek commented 12 years ago

We could have an id: @foo.bar instead of host: mongodb://localhost:27017 (though that should also remain possible IMO if you only use mongo for logging). If it's provided you just use a new Reference($handler['id']) instead of that new Mongo.

You can look at the Gelf config for inspiration: https://github.com/symfony/MonologBundle/blob/master/DependencyInjection/MonologExtension.php#L133-148

florianeckerstorfer commented 12 years ago

@Seldaek I've tried to implement this as you described, however I end up with a circular reference.

The problem is that Doctrine\MongoDB\Connection only returns a \Mongo object after it has been initialised (with the method initialize and that at that point Doctrine requires a Monolog logger.

Any suggestions how this can be implemented?

stof commented 12 years ago

@florianeckerstorfer you have to use a mongo connection with logging disabled if you want to get it from the doctrine connection.

pacoVela commented 10 years ago

Is anyone working in mongodb handler?

Seldaek commented 10 years ago

I don't think so. I looked into it but it seemed non-trivial to wire up the doctrine mongo stuff etc so I gave up. If you'd like to give it a shot it would be much appreciated.

pacoVela commented 10 years ago

I'm wondering if doctrine is really necessary here. We can make the connection with a simple service, or directly with host/port/user/pass params. So you can use the same params for doctrine and monolog configurations, but it's only a matter of taste.

I agree with you that it is not trivial to do it with doctrine.

wheelsandcogs commented 10 years ago

My concern was duplicating the config if you were already using doctrine, and possibly the overhead of having another connection just for logging. Obviously it would be nicer to re-use the existing config and connection if possible, but I'd rather have a working mongodb handler with extra config than no handler at all.

pacoVela commented 10 years ago

Using params you don't have to repeat the literals for database host, and user... So you're true, the only caveat here is the overhead by the existence of another connection. In my case this is needed because we use a server just for logs.

pacoVela commented 10 years ago

I have the mongodb basic implementation ready to merge, (without doctrine stuff). https://github.com/pacoVela/MonologBundle

kingcrunch commented 10 years ago

It looks like the list in the initial description isn't up to date anymore?

Seldaek commented 10 years ago

@KingCrunch care to elaborate? I usually try to update it but maybe I missed one.

kingcrunch commented 10 years ago

@Seldaek I meant the list in this PR (above). I cannot edit that.

Seldaek commented 10 years ago

Yes I can update it but what is not up to date exactly?

emgiezet commented 10 years ago

I will add here the errbit / airbrake handler if its possible.

Seldaek commented 10 years ago

@emgiezet not sure what these have to do with monolog? Are there handlers out there somewhere that I don't know of?

fotomerchant commented 10 years ago

I've just submitted https://github.com/symfony/MonologBundle/pull/92 for Slack support. Also submitted https://github.com/Seldaek/monolog/pull/377 @Seldaek to add support to monolog SlackHandler for the emoji icons used by Slack.

Example conifg:

slack:
            type: slack
            token: xxxxxxx
            channel: C9342CD
            bot_name: YourBotName
            use_attachment: true
            icon_emoji: monkey_face
            level: error

mpdude commented 9 years ago

Support for the WhatFailureGroupHandler is in #107.