search

symfony / orm-pack

A Symfony Pack for Doctrine ORM
MIT License
1.82k stars 18 forks source link

Stick to v2 of doctrine/* #28

Closed nicolas-grekas closed 4 years ago

nicolas-grekas commented 4 years ago

Fix #18 Similar to #25 I failed at other approaches I was advocating :) The World is not ready for migration v3, neither for dbal v3 not orm v3 when they'll be released.

To be tagged as v1.1.0

If you need v3, unpack. See #29.

olix21 commented 4 years ago

Me too. I guess they are planning a 2.0 tag with the new doctrine version...

I'm reverting to 1.0.8 so I can keep the doctrine migration v3

nicolas-grekas commented 4 years ago

Don't stick, unpack instead. See #29.

Addvilz commented 4 years ago

Migrations 2 is not forwards compatible with migrations 3. Unpack is not an option, at least for me - I don't want to track each of these dependencies individually across all codebases.

I will pin to 1.0.8 at the time being till orm-pack is updated to 3.

mmarton commented 4 years ago

This is not a "fix" to any real problem. If somewone doesn't want the newer version, they could stick to the old version by fixing it in their compose.json, they don't even needed to unpack. Why would soneone upgrade the orm pack and not upgrade it's dependencies? Why is it a solution to block progress, make the old one default and enforce everyone to use that (or to unpack)? Why should it take extra steps to have the latest dependencies if I start a new project? I've already updated my projects to the v3, took me about 5 minute/project....

nicolas-grekas commented 4 years ago

See https://github.com/symfony/orm-pack/pull/30 about allowing v3 again.