search

symfony / orm-pack

A Symfony Pack for Doctrine ORM
MIT License
1.82k stars 18 forks source link

Proposing the addition of DoctrineMigrationsBundle to the pack #8

Closed weaverryan closed 6 years ago

weaverryan commented 6 years ago

Hi guys!

This makes the pack a bit more opinionated, but I think it make sense:

A) DoctrineMigrationsBundle is the "official" migrations library for Doctrine B) Most/All frameworks package migrations functionality with their ORM.

Thanks!

fabpot commented 6 years ago

Cannot be merged as DoctrineMigrationsBundle does not allow Symfony 4 for now. Should wait for doctrine/DoctrineMigrationsBundle#212 to be merged first and a new release.

garak commented 6 years ago

I disagree. I often don't need migrations at all, and forcing this is overkill.

weaverryan commented 6 years ago

@garak you can of course still install doctrine/orm and doctrine/doctrine-bundle independently if you want more control over your deps :). The goal with the packs is to package things together that cover the 90% use-case.

garak commented 6 years ago

That's exactly what I did. I think it's a pity anyway, I'd prefer a pack that cover 100% use-case, letting details to more specific needs