Rename PANTHER_NO_HEADLESS to PANTHER_HEADLESS

symfony / panther

A browser testing and web crawling library for PHP and Symfony

MIT License

2.94k stars 221 forks source link

Rename PANTHER_NO_HEADLESS to PANTHER_HEADLESS #127

Open maidmaid opened 5 years ago

maidmaid commented 5 years ago

PANTHER_NO_HEADLESS env var gave me many headaches...

headless means "hidden", so "no headless" means "no hidden" , so "show". If in the code we use "! no headless", that means "no no hidden", so "yes hidden", so "show". Why not get rid of this double negation by simply renaming it PANTHER_HEADLESS ?

dunglas commented 5 years ago

Ok for me!