search

symfony / panther

A browser testing and web crawling library for PHP and Symfony
MIT License
2.91k stars 213 forks source link

Make Panther PHPUnit 10 compatible #588

Closed arderyp closed 10 months ago

arderyp commented 1 year ago

Now that PHPUnit 10 is out, I'm adding this issue to the queue

arderyp commented 1 year ago

if no one is working on this, I may be able to dedicate some time to looking into it.

@dunglas, since PHPUnit 10 is a substantial refactor, I am not yet sure how feasible it would be for Panther to support, for example, both 9 and 10. It looks like Panther isn't actually dependent directly on phpunit/phpunit, but rather symfony/phpunit-bridge, which is also not PHPUnit 10 compatible.

Do you think work on this issue should wait until after phpunit-bridge supports 10?

Do you intend to attempt to support multiple PHPUnit versions, or would this issue warrant a new major 3 release and dropped support for PHPUnit <10?

arderyp commented 1 year ago

it looks like doctrine-test-bundle does handle support for multiple php version, so maybe this is doable here as well: https://github.com/dmaicher/doctrine-test-bundle/blob/master/src/DAMA/DoctrineTestBundle/PHPUnit/PHPUnitExtension.php

Chris53897 commented 10 months ago

@arderyp Thanks for your hard work here. Maybe you can close this issue as completed?