search

symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
965 stars 476 forks source link

[symfony/ux-translator] TranslatorBundle class now prefixed by Ux #1196

Closed r-huyvaert closed 1 year ago

r-huyvaert commented 1 year ago
Q A
License MIT
Doc issue/PR N/A

The class TranslatorBundle of the Symfony UX Translator component has recently been renamed to UxTranslatorBundle (Commit bc96739).

Currenty, the following line added to the bundles.php file is as the following :

Symfony\UX\Translator\TranslatorBundle::class => ['all' => true],

It needs to be renamed here too so it won't lead to the following error after the install :

image

github-actions[bot] commented 1 year ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1196/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1196/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/ux-translator:^2.7'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

Kocal commented 1 year ago

Thanks!

This was modified to prevent bundle loading issue with the Symfony Translator, but I forgot to modify it in #1185 which was merged with a broken CI.