Comment <extensions> tag before PHPUnit 9.6

nicolas-grekas commented 1 year ago

Q	A
License	MIT
Doc issue/PR	-

See https://github.com/sebastianbergmann/phpunit/pull/5419 for background.

github-actions[bot] commented 1 year ago

Thanks for the PR 😍

How to test these changes in your application

Define the SYMFONY_ENDPOINT environment variable:

# On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1219/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1219/index.json

Install the package(s) related to this recipe:

composer req 'symfony/flex:^1.16'
composer req 'phpunit/phpunit:^9.6' 'symfony/phpunit-bridge:^6.3'

Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

# On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

phpunit/phpunit

4.7 vs 9.3

```diff diff --git a/phpunit/phpunit/4.7/phpunit.xml.dist b/phpunit/phpunit/9.3/phpunit.xml.dist index db2b29d..23ea5cf 100644 --- a/phpunit/phpunit/4.7/phpunit.xml.dist +++ b/phpunit/phpunit/9.3/phpunit.xml.dist @@ -6,12 +6,15 @@ backupGlobals="false" colors="true" bootstrap="tests/bootstrap.php" + convertDeprecationsToExceptions="false" > + + @@ -20,11 +23,11 @@ - - + + src - - + + ```

9.3 vs 9.6

```diff diff --git a/phpunit/phpunit/9.3/phpunit.xml.dist b/phpunit/phpunit/9.6/phpunit.xml.dist index 23ea5cf..6c4bfed 100644 --- a/phpunit/phpunit/9.3/phpunit.xml.dist +++ b/phpunit/phpunit/9.6/phpunit.xml.dist @@ -33,8 +33,6 @@ - ```

symfony/phpunit-bridge

3.3 vs 4.1

```diff diff --git a/symfony/phpunit-bridge/3.3/.env.test b/symfony/phpunit-bridge/4.1/.env.test index 24a43c0..9e7162f 100644 --- a/symfony/phpunit-bridge/3.3/.env.test +++ b/symfony/phpunit-bridge/4.1/.env.test @@ -2,3 +2,5 @@ KERNEL_CLASS='App\Kernel' APP_SECRET='$ecretf0rt3st' SYMFONY_DEPRECATIONS_HELPER=999999 +PANTHER_APP_ENV=panther +PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots diff --git a/symfony/phpunit-bridge/3.3/bin/phpunit b/symfony/phpunit-bridge/4.1/bin/phpunit index 0b79fd4..63dae24 100755 --- a/symfony/phpunit-bridge/3.3/bin/phpunit +++ b/symfony/phpunit-bridge/4.1/bin/phpunit @@ -6,12 +6,6 @@ if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-php exit(1); } -if (false === getenv('SYMFONY_PHPUNIT_VERSION')) { - putenv('SYMFONY_PHPUNIT_VERSION=6.5'); -} -if (false === getenv('SYMFONY_PHPUNIT_REMOVE')) { - putenv('SYMFONY_PHPUNIT_REMOVE=symfony/yaml'); -} if (false === getenv('SYMFONY_PHPUNIT_DIR')) { putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit'); } diff --git a/symfony/phpunit-bridge/3.3/phpunit.xml.dist b/symfony/phpunit-bridge/4.1/phpunit.xml.dist index 294a559..d81f0c3 100644 --- a/symfony/phpunit-bridge/3.3/phpunit.xml.dist +++ b/symfony/phpunit-bridge/4.1/phpunit.xml.dist @@ -8,10 +8,11 @@ bootstrap="tests/bootstrap.php" > - + + @@ -21,8 +22,8 @@ - - src + + src ```

4.1 vs 4.3

```diff diff --git a/symfony/phpunit-bridge/4.1/bin/phpunit b/symfony/phpunit-bridge/4.3/bin/phpunit index 63dae24..4d1ed05 100755 --- a/symfony/phpunit-bridge/4.1/bin/phpunit +++ b/symfony/phpunit-bridge/4.3/bin/phpunit @@ -1,8 +1,8 @@ #!/usr/bin/env php + ```

4.3 vs 5.1

```diff diff --git a/symfony/phpunit-bridge/4.3/phpunit.xml.dist b/symfony/phpunit-bridge/5.1/phpunit.xml.dist index 5766779..40593c6 100644 --- a/symfony/phpunit-bridge/4.3/phpunit.xml.dist +++ b/symfony/phpunit-bridge/5.1/phpunit.xml.dist @@ -8,12 +8,11 @@ bootstrap="tests/bootstrap.php" > - - + @@ -31,4 +30,9 @@ + + ```

5.1 vs 5.3

```diff diff --git a/symfony/phpunit-bridge/5.1/bin/phpunit b/symfony/phpunit-bridge/5.3/bin/phpunit index 4d1ed05..f26f2c7 100755 --- a/symfony/phpunit-bridge/5.1/bin/phpunit +++ b/symfony/phpunit-bridge/5.3/bin/phpunit @@ -1,13 +1,19 @@ #!/usr/bin/env php + - + @@ -21,11 +23,11 @@ - - + + src - - + + diff --git a/symfony/phpunit-bridge/5.1/post-install.txt b/symfony/phpunit-bridge/5.3/post-install.txt index 2db39ab..e9da2a6 100644 --- a/symfony/phpunit-bridge/5.1/post-install.txt +++ b/symfony/phpunit-bridge/5.3/post-install.txt @@ -1,2 +1,3 @@ * Write test cases in the tests/ folder - * Run php bin/phpunit + * Use MakerBundle's make:test command as a shortcut! + * Run the tests with php bin/phpunit ```

5.3 vs 6.3

```diff diff --git a/symfony/phpunit-bridge/5.3/manifest.json b/symfony/phpunit-bridge/6.3/manifest.json index 4fb292b..482a1a4 100644 --- a/symfony/phpunit-bridge/5.3/manifest.json +++ b/symfony/phpunit-bridge/6.3/manifest.json @@ -9,5 +9,8 @@ ".phpunit.result.cache", "/phpunit.xml" ], + "conflict": { + "phpunit/phpunit": "<9.6" + }, "aliases": ["simple-phpunit"] } diff --git a/symfony/phpunit-bridge/5.3/phpunit.xml.dist b/symfony/phpunit-bridge/6.3/phpunit.xml.dist index 23ea5cf..6c4bfed 100644 --- a/symfony/phpunit-bridge/5.3/phpunit.xml.dist +++ b/symfony/phpunit-bridge/6.3/phpunit.xml.dist @@ -33,8 +33,6 @@ - ```

damienalexandre commented 1 year ago

This may have been merged too soon maybe?

The fix in phpunit allowing empty tag is not yet available, by updating my phpunit/phpunit recipe I got this error:

PHPUnit 9.6.9 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 36:
  - Element 'extensions': Missing child element(s). Expected is ( extension ).

  Test results may not be as expected.

Anyway, we just have to wait ^^

stof commented 1 year ago

indeed, we would also have to comment it before phpunit 6.9.10

symfony / recipes