symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
965 stars 476 forks source link

Add Recipe for PHPUnit 10 #1239

Open alexander-schranz opened 1 year ago

alexander-schranz commented 1 year ago
Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

This will add a recipe for PHPUnit 10:

Following changes:

github-actions[bot] commented 1 year ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1239/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1239/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'phpunit/phpunit:^10.0' 'symfony/panther:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

phpunit/phpunit

4.7 vs 9.3 ```diff diff --git a/phpunit/phpunit/4.7/phpunit.xml.dist b/phpunit/phpunit/9.3/phpunit.xml.dist index db2b29d..23ea5cf 100644 --- a/phpunit/phpunit/4.7/phpunit.xml.dist +++ b/phpunit/phpunit/9.3/phpunit.xml.dist @@ -6,12 +6,15 @@ backupGlobals="false" colors="true" bootstrap="tests/bootstrap.php" + convertDeprecationsToExceptions="false" > + + @@ -20,11 +23,11 @@ - - + + src - - + + ```
9.3 vs 9.6 ```diff diff --git a/phpunit/phpunit/9.3/phpunit.xml.dist b/phpunit/phpunit/9.6/phpunit.xml.dist index 23ea5cf..6c4bfed 100644 --- a/phpunit/phpunit/9.3/phpunit.xml.dist +++ b/phpunit/phpunit/9.6/phpunit.xml.dist @@ -33,8 +33,6 @@ - ```
9.6 vs 10.0 ```diff diff --git a/phpunit/phpunit/9.6/.env.test b/phpunit/phpunit/10.0/.env.test index 9e7162f..24a43c0 100644 --- a/phpunit/phpunit/9.6/.env.test +++ b/phpunit/phpunit/10.0/.env.test @@ -2,5 +2,3 @@ KERNEL_CLASS='App\Kernel' APP_SECRET='$ecretf0rt3st' SYMFONY_DEPRECATIONS_HELPER=999999 -PANTHER_APP_ENV=panther -PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots diff --git a/phpunit/phpunit/9.6/manifest.json b/phpunit/phpunit/10.0/manifest.json index 8af7b3b..a35670a 100644 --- a/phpunit/phpunit/9.6/manifest.json +++ b/phpunit/phpunit/10.0/manifest.json @@ -1,11 +1,11 @@ { "copy-from-recipe": { ".env.test": ".env.test", - "phpunit.xml.dist": "phpunit.xml.dist", + "phpunit.dist.xml": "phpunit.dist.xml", "tests/": "tests/" }, "gitignore": [ "/phpunit.xml", - ".phpunit.result.cache" + "/.phpunit.cache/" ] } diff --git a/phpunit/phpunit/9.6/phpunit.xml.dist b/phpunit/phpunit/10.0/phpunit.dist.xml similarity index 72% rename from phpunit/phpunit/9.6/phpunit.xml.dist rename to phpunit/phpunit/10.0/phpunit.dist.xml index 6c4bfed..7ca7d74 100644 --- a/phpunit/phpunit/9.6/phpunit.xml.dist +++ b/phpunit/phpunit/10.0/phpunit.dist.xml @@ -6,7 +6,7 @@ backupGlobals="false" colors="true" bootstrap="tests/bootstrap.php" - convertDeprecationsToExceptions="false" + cacheDirectory=".phpunit.cache" > @@ -14,7 +14,7 @@ - + @@ -23,15 +23,11 @@ - + - src + src - - - - - + ```
alexander-schranz commented 9 months ago

Anything I need to tackle here?

b-durand commented 5 months ago

Hello, what are the conditions for validating this request? New Symfony projects don't have a valid default configuration.