search

symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
956 stars 472 forks source link

[AssetMapper] Exclude _*.scss files #1241

Closed Kocal closed 6 months ago

Kocal commented 10 months ago
Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

See https://github.com/symfony/ux/pull/1111

cc @weaverryan

github-actions[bot] commented 10 months ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1241/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1241/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/asset-mapper:^6.3'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

weaverryan commented 9 months ago

Hmm, on second thought, perhaps we should add this to the SassBundle documentation? It looks weird to me to have sass-specific config by default with AssetMapper.

fabpot commented 6 months ago

Closing as explained by @weaverryan