Closed AurelienPillevesse closed 10 months ago
Thanks for the PR 😍
Define the SYMFONY_ENDPOINT
environment variable:
# On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1253/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1253/index.json
Install the package(s) related to this recipe:
composer req 'symfony/flex:^1.16'
composer req 'symfony/framework-bundle:^7.0'
Don't forget to unset the SYMFONY_ENDPOINT
environment variable when done:
# On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=
In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.
When I added Sonar to analyze my project. I looked without vendor folder restriction and it suggested to change it from require
to require_once
so I created a PR in case it was a mistake. If not, we can close it.
In theory that file should be included only once... if for some reason it's included twice - you will see a clear error because that's an architectural error. In such cases require
make life simpler, unless we're talking about requiring your custom classes when it may happen
Well, the question is what does it actually solve, not whether Sonar just reported that without any real-world impact.
Thanks for opening this!
I agree - unless this is solving a real issue, there's not a compelling enough reason to make this change.
Cheers!
Improving
require
torequire_once
for all maintained Symfony versions (5.4, 6.4 and 7.0).