symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
956 stars 472 forks source link

[CI] Update CI for 'Create-project with skeleton ^6' step #1254

Closed AurelienPillevesse closed 8 months ago

AurelienPillevesse commented 8 months ago
Q A
License MIT
Doc issue/PR None

Update CI for 'Create-project with skeleton ^6' step.

github-actions[bot] commented 8 months ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1254/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1254/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

AurelienPillevesse commented 8 months ago

Don't really understand why CI is failing right now. Wanted to fix one of the issues visible in this one : https://github.com/symfony/recipes/pull/1253 (caused by PHP version)

AurelienPillevesse commented 8 months ago

image

About the other error in the CI, I can see that symfony/symfony ^5.4 is downloading symfony/framework-bundle ^7.0. Do you know if it's normal or not, I don't know enough this part ? @nicolas-grekas @fabpot

AurelienPillevesse commented 8 months ago

My bad, I saw that it's Symfony 7.0 which will need PHP 8.2. Not the version ^6.

weaverryan commented 8 months ago

About the other error in the CI, I can see that symfony/symfony ^5.4 is downloading symfony/framework-bundle ^7.0. Do you know if it's normal or not, I don't know enough this part ?

I'm not sure. It comes from the composer require -W --ansi $PACKAGES line in the CI. That $PACKAGES I believe is an attempt to fetch the packages affected by the PR - https://github.com/symfony/recipes/pull/1254/files#diff-a63af90bcded38e234e48f5a253229ba26cfbcef5271976a3e39a8c8b3c86894R239 - and if the 7.0 version of symfony/framework-bundle is affected by the recipe, then it tries to install it. I'm not really sure how to fix that - we'd need to know which packages are / are not compatible with different Symfony versions. So, this is tricky - and maybe we are ok with it and just let the CI be a helpful guide, not something that always needs to pass.