search

symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
956 stars 472 forks source link

[Doctrine Bundle] Pin versions in Dockerfile #1266

Closed LaurentSanson closed 7 months ago

LaurentSanson commented 7 months ago

Hi there,

I've encountered a small issue with the ORM bundle recipe and using the Hadolint on the CI (it all come from the Kevin's template).

Issue : Error: Dockerfile:51 DL3018 warning: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

How to reproduce :

I'm guessing we could probably add a version of the package in the recipe as suggested?

Thanks !

maxhelias commented 7 months ago

Hello, This error should no longer occur with the latest version of recipes : https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.9/manifest.json#L19

LaurentSanson commented 7 months ago

Oh great !! Thanks for the quick feedback

LaurentSanson commented 7 months ago

@maxhelias I've just checked the recipes. The one you pointed at is the 2.9 and it's not the latest as there is a 2.10 => https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.10/manifest.json#L18

maxhelias commented 7 months ago

I missed 2.10.. which should have the same dockerfile section as 2.9...

LaurentSanson commented 7 months ago

No probs, I've created the PR. Tell me if it needs more info :)