search

symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
953 stars 472 forks source link

Add recipes for symfonycasts/sass-bundle #1278

Open makraz opened 6 months ago

makraz commented 6 months ago
Q A
License MIT
Doc issue/PR symfony/symfony-docs#...
github-actions[bot] commented 6 months ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1278/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1278/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfonycasts/sass-bundle:^0.5'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

fabpot commented 5 months ago

@weaverryan Can you review this one please?

rosier commented 5 months ago

It looks like there is a space in the path of symfonycasts/sass-bundle/0.4/assets /styles/app.scss at the end of assets.

Is that intended?

makraz commented 5 months ago

It looks like there is a space in the path of symfonycasts/sass-bundle/0.4/assets /styles/app.scss at the end of assets.

Is that intended?

good catch, thank you, I fixed it 👍🏼