symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
953 stars 472 forks source link

Update docker image for Mailcatcher #1279

Closed ker0x closed 5 months ago

ker0x commented 6 months ago
Q A
License MIT
Doc issue/PR -

This PR replace the unmaintained schickling image with the official Mailcatcher image

github-actions[bot] commented 6 months ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1279/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1279/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/mailer:^4.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

ker0x commented 6 months ago

Another possibility would be to replace Mailcatcher with Mailpit, which offers many more features and a much lighter image (27 MB for Mailpit compared to 90 MB for Mailcatcher).

kbond commented 5 months ago

Another possibility would be to replace Mailcatcher with Mailpit, which offers many more features and a much lighter image (27 MB for Mailpit compared to 90 MB for Mailcatcher).

Mailpit does look nice, perhaps discuss in another PR?

ker0x commented 5 months ago

@kbond done, see #1281 😉