search

symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
953 stars 472 forks source link

Explicit Messenger bus configuration #1298

Closed priyadi closed 3 months ago

priyadi commented 4 months ago
Q A
License MIT
Doc issue/PR

Make bus configuration in messenger.yaml explicit to facilitate third-party bundles providing their bus configuration.

Without this configuration, if a bundle provides a bus configuration via a flex recipe, it silently becomes the default bus. Or if there is already a bus configuration, but without the default_bus setting, it will give us _"Invalid configuration for path "framework.messenger": You must specify the "defaultbus" if you define more than one bus."

github-actions[bot] commented 4 months ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1298/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1298/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/webapp-pack:^1.0'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.