symfony / recipes

Symfony Recipes Repository
https://github.com/symfony/recipes/blob/flex/main/RECIPES.md
MIT License
959 stars 476 forks source link

[Notifier] Enable auto-configuration for the `GoIP` bridge #1326

Closed ahmedghanem00 closed 1 month ago

ahmedghanem00 commented 1 month ago
Q A
License MIT
Doc issue/PR

This has been forgotten to be set/enabled when the recipe was introduced for the first time.

github-actions[bot] commented 1 month ago

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1326/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1326/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/go-ip-notifier:^6.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. I'm going keep this comment up to date with any updates of the attached patch.

ahmedghanem00 commented 1 month ago

@OskarStark Thanks for the review. It's notable also that since this package was renamed last year from the old name goip-notifier to the new name go-ip-notifier, the old name is still present on Packagist here ​​and the package can only be downloaded/installed via this old name.

This also makes the package recipe here not work correctly because Flex assumes the new name 😞. So, someone with proper access to Packagist may do the renaming there as well? (abandon the package with the old name and then re-publish it again under the new name)

OskarStark commented 1 month ago

friendly ping @fabpot