search

symfony / security-acl

Symfony Security ACL Component
https://symfony.com/components/Security
MIT License
363 stars 48 forks source link

getUserIdentifier() instead of getUsername() in SF5.3 and higher? #110

Open rsvitak opened 1 year ago

rsvitak commented 1 year ago

I am sorry, this is likely a question than an issue report. An answer will actually help me to understand things.

On several places like this, https://github.com/symfony/security-acl/blob/f24881ebade00b4f186df2828b22f6ecf5045866/Dbal/MutableAclProvider.php#L563 there is the getUsername call, but, if the UserInterface::getUsername is deprecated since SF5.3, is it going to be replaced by getUserIdentifier() in the security-acl bundle too?

wouterj commented 1 year ago

Hi! As far as I'm concerned, the ACL component and bundle are treated as "maintained by the community".

The core team does their best to merge new PRs, keep the build green and release versions, but we don't actively maintain or change anything in these packages. So even more than on the main repository, there is no roadmap and there are no plans for the ACL packages.

That said, if you think it makes sense to rename the method, you're free to start a PR imho :)