search

symfony / security-acl

Symfony Security ACL Component
https://symfony.com/components/Security
MIT License
362 stars 49 forks source link

Fix Symfony 7 compatibility #116

Open core23 opened 8 months ago

core23 commented 8 months ago

Fixes https://github.com/symfony/security-acl/issues/114 by providing the correct method signature, depending on the loaded symfony/security-core version.

Might close: #112 #115 #114

core23 commented 7 months ago

Is there anything left to do? This blocks symfony 7 updates :(

VincentLanglet commented 7 months ago

Is there anything left to do? This blocks symfony 7 updates :(

Friendly ping @nicolas-grekas maybe (?)

core23 commented 7 months ago

Two ✅

Can be merge this @nicolas-grekas ?

chq81 commented 4 months ago

@core23 Thanks for working on the symfony 7 compatibility. I stumbled upon this and saw that checks are failing due to deprecations. I was able to fix them locally. I could provide a separate PR, but wouldn't it be better to provide the code to you? Should I create a PR in your fork which you then can merge in your symfony7 branch?

core23 commented 4 months ago

AFAIK they are not related to this PR, so it would be better to fix this deprecation issues on the main project first.

chq81 commented 4 months ago

AFAIK they are not related to this PR, so it would be better to fix this deprecation issues on the main project first.

I will do that, thanks.

chq81 commented 4 months ago

@core23 I just had a look. As the current tagged version is 3.3.3, which bumped Symfony up to 7, I cannot fix the deprecation warnings without fixing the return type declarations too, which are part of your PR :)

chq81 commented 4 months ago

@nicolas-grekas Hi Nicolas, could you maybe help out? How should we proceed with the deprecation warnings? I could either bump up the code to the current implementation, but then the lowest versions are not supported anymore. Or do we disable deprecations on the highest versions? I am a bit of lost here, but as I am not a regular commiter in github, maybe you can help me out? Thanks!

p-golovin commented 1 month ago

Hi all, any news on this?

jordisala1991 commented 4 weeks ago

I created a new PR that includes this commit and fixes all builds #121