search

symfony / security-acl

Symfony Security ACL Component
https://symfony.com/components/Security
MIT License
362 stars 49 forks source link

CS: Ensure that offsets starts from 0 #24

Closed saiditec closed 5 years ago

saiditec commented 8 years ago

Avoid undefined offset when walking $new and $old arrays

xabbuh commented 8 years ago

Can you add a test to avoid regressions?

xabbuh commented 8 years ago

The test as is right now does not add any value. A good test would use the component's public API in a way that the old code led to a wing result. Currently, you do not execute any code that was changed at all through the test.

francoispluchino commented 7 years ago

This Pull Request is incomplete and does not solve the whole problem, see the issue #28 for more details.

fabpot commented 5 years ago

Closing as there is no more activity here.