search

symfony / security-acl

Symfony Security ACL Component
https://symfony.com/components/Security
MIT License
362 stars 49 forks source link

Update tests #59

Closed fabpot closed 3 years ago

fabpot commented 4 years ago

If someone wants to help, one can help update the tests to modern PHPUnit. Right now, we still have some getMock() calls, and tests with no assertions.

thamerbelfkihthamer commented 3 years ago

@fabpot this one is still valid?

OskarStark commented 3 years ago

As this is not merged yet, I would say yes

acrobat commented 3 years ago

I've started a new PR #66 that fixes this issue and adds a github actions setup so that new PR's will be tested before merging.