Drop support for Symfony 3

symfony / security-acl

Symfony Security ACL Component

https://symfony.com/components/Security

MIT License

363 stars 48 forks source link

Drop support for Symfony 3 #78

Closed derrabus closed 3 years ago

derrabus commented 3 years ago

This PR proposes to perform the version bumps that we've done on https://github.com/symfony/acl-bundle already:

Symfony 4.4
PHP 7.2

Symfony 3 is EOL and we don't develop features for PHP 7.1 anymore. This would also allow us to drop some compatibility code as well as modernize methods with property type declarations.

derrabus commented 3 years ago

~~Apparently, getReachableRoleNames did not exist on Symfony 4.4 already. I'll revert that part later.~~ Done.

acrobat commented 3 years ago

Would it be an option to first release a minor with the dbal 2.13 compatibility fixes? And have this PR included in the next minor?

derrabus commented 3 years ago

Would it be an option to first release a minor with the dbal 2.13 compatibility fixes? And have this PR included in the next minor?

I can tag a patch release for the DBAL compatibility, I suppose.

derrabus commented 3 years ago

@acrobat v3.1.2 was tagged.

acrobat commented 3 years ago

Thanks @derrabus!