symfony / security-acl

Symfony Security ACL Component
https://symfony.com/components/Security
MIT License
363 stars 48 forks source link

Improve AclInterface phpdoc #84

Closed VincentLanglet closed 2 years ago

VincentLanglet commented 2 years ago

HI @derrabus @wouterj,

The following code (really simplified)

foreach ($acl->getObjectAces() as $currentIndex => $currentAce) {
    $acl->updateObjectAce($currentIndex, $mask);
 }

is reporting an issue with static analysis because, updateObjectAce expect an int, but the index of getObjectAces can be int|string. So I updated the phpdoc to restrict it to int.

VincentLanglet commented 2 years ago

Btw, I'm sure you don't mean it that way, but I prefer not to be pinged directly. I'm subscribed to all activities in Symfony packages, so I'll see your PR whenever I want to look for new PRs.

Sure, sorry.

derrabus commented 2 years ago

Thank you @VincentLanglet.