search

symfony / skeleton

The Symfony skeleton
MIT License
598 stars 128 forks source link

Use stable stability for the 5.3 skeleton #196

Closed stof closed 3 years ago

stof commented 3 years ago

Using minimum-stability: dev with prefer-stable: true does not guarantee at all that you get a solver solution using only stable deps if it exists. That's because prefer-stable: true affects local decisions, not a global selection between solutions (because the solver won't look for multiple solutions anyway). See https://github.com/composer/composer/issues/9917 for an example. For stable symfony versions, it is better to stick with the composer default of using minimum-stability: stable, to avoid surprises (I saw some people reporting on Slack during the stabilization phase that the orm-pack ended up instead doctrine/orm 3.0.x-dev for them in some cases, which is far from being ready, for instance).

nicolas-grekas commented 3 years ago

Would revert #192. I'm mostly :-1: here because in practice this solves more issues than it theoretically creates.

the orm-pack ended up instead doctrine/orm 3.0.x-dev for them in some cases

correct, but that happened because we were missing prefer-stable and has been fixed in https://github.com/symfony/skeleton/commit/6ac5c1d9e0472a7da15490fc307e222ed3255ee1

stof commented 3 years ago

correct, but that happened because we were missing prefer-stable and has been fixed in 6ac5c1d

Please see the link to the composer issue I linked. prefer-stable does not guarantee you that the stable release will be selected for a package even for a case where a solver solution exists for minimum-stability: stable (if that solution involves choosing a different version of another package)

nicolas-grekas commented 3 years ago

OK, let's do this. I'm merging into 5.2.

nicolas-grekas commented 3 years ago

Merged as 82df7071034a5d9d7d69e5bf9d2e504ab9b4cd82 (keeping the lines to reduce the diff)