search

symfony / skeleton

The Symfony skeleton
MIT License
598 stars 128 forks source link

Bump Flex to 1.17 #198

Closed derrabus closed 3 years ago

derrabus commented 3 years ago

Following https://symfony.com/blog/upgrade-flex-on-your-symfony-projects

The blog article tells the world not to use Flex versions older than 1.17. I think it would be wise to update the skeleton to reflect this request.

nicolas-grekas commented 3 years ago

We won't retag the skeleton for older versions, but I'm fine doing this on 5.4 In practice this shouldn't matter since composer will always select the latest.

derrabus commented 3 years ago

Okay, let's merge to 5.4 then.

In practice this shouldn't matter since composer will always select the latest.

That is correct. However, this constraint will be persisted in the composer.json file of every new Symfony application that will be created from the skeleton. If we discourage the use of older versions, I believe that letting new applications start with that constraint is a good way to document that.

fabpot commented 3 years ago

I'm fine with this change. At the very least, it sends a "subtle" message in the right direction :)

nicolas-grekas commented 3 years ago

Thank you @derrabus.