search

symfony / stimulus-bridge

Stimulus integration bridge for Symfony projects
https://symfony.com/ux
75 stars 15 forks source link

Add workflow to verify dist build #22

Closed chapterjason closed 3 years ago

chapterjason commented 3 years ago

This workflow builds the plugin and check if there are any git changes, if so the the build will fail. This ensures that the dist output will always be the latest.

weaverryan commented 3 years ago

Hey @chapterjason!

This IS something we need to prevent. But actually, the proper solution is to commit NOT dist files and to build them on release - we were talking about it recently here: https://github.com/symfony/stimulus-bridge/pull/15#discussion_r564649672

So, if you're interesting, I think that would be awesome to properly have :). We can work in including less dist files (another topic of that thread) in another PR after a few recent PR's are merged.

Thanks!

chapterjason commented 3 years ago

@weaverryan You are absolutely right. We should not build up too much technical debt.

Closing this then. An issue for discussion would be great.