search

symfony / stimulus-bridge

Stimulus integration bridge for Symfony projects
https://symfony.com/ux
75 stars 15 forks source link

Fix types import #36

Closed chapterjason closed 2 years ago

chapterjason commented 3 years ago

As I thought on the first PR https://github.com/symfony/stimulus-bridge/pull/8#discussion_r562621068 imports should be declared inside the module declaration otherwise it can cause errors like: 

TS2665: Invalid module name in augmentation. Module '@symfony/stimulus-bridge' resolves to an untyped module at '[...]/node_modules/@symfony/stimulus-bridge/dist/index.js', which cannot be augmented.

source: https://stackoverflow.com/a/48846446

weaverryan commented 2 years ago

Hey @chapterjason!

I know it's been awhile, but how were you seeing that error? The types seem to work fine for me - I also moved them into the package itself in #55.

Cheers!

chapterjason commented 2 years ago

Hey @weaverryan

I saw your pr, its the way I proposed the first time. 😄 #8

I would say let's close this one and improve yours.