Supporting Stimulus 3 - Githubissues

symfony / stimulus-bridge

Stimulus integration bridge for Symfony projects

https://symfony.com/ux

75 stars 15 forks source link

Supporting Stimulus 3 #48

Closed weaverryan closed 2 years ago

weaverryan commented 2 years ago

Adds support for Stimulus 3. Unless we get fancy (which we could I think, but it's a bit unnatural), this will require a new major release of this library.

TODOs:

[x] @symfony/stimulus-testing needs to be updated to work with Stimulus 3
[x] Fix tests (depends on above)

Before a tag, we need to

[ ] Upgrade the symfony/ux packages to support Stimulus v3.

stof commented 2 years ago

Unless we get fancy (which we could I think, but it's a bit unnatural)

I don't see how you could get fancy. Changing peer dependencies is a BC break.

weaverryan commented 2 years ago

Yup, the “fancy” would require not listing either as a peer dependency and hoping for the best. So not really an option :)

tgalopin commented 2 years ago

Thanks @weaverryan.