symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.18k stars 5.12k forks source link

Allow AbstractDoctrineExtension implementations to support the newer bu… #16110

Closed fabpot closed 1 year ago

fabpot commented 2 years ago
Q A
Feature PR symfony/symfony#43181
PR author(s) @mbabker
Merged in 5.4
mbabker commented 2 years ago

Someone can surely find a better way to describe this than me, but...

In the https://github.com/symfony/symfony-docs/blob/5.4/bundles/best_practices.rst#doctrine-entitiesdocuments section, when a bundle supports Symfony 5.4 (or, most specifically, the Doctrine Bridge at 5.4) and DoctrineBundle 2.5 (for ORM entities) or whatever version of DoctrineMongoDBBundle https://github.com/doctrine/DoctrineMongoDBBundle/pull/713 lands in (for MongoDB ODM documents), the mapping files should be stored in config/doctrine. If supporting older versions of those dependencies, the Resources/config/doctrine path should still be used unless you want to deal with symlinks or manually register mapping paths.

That's probably the only change needed for the Symfony docs as the actual convention ends up being defined by a bundle or any implementation of AbstractDoctrineExtension and not the Doctrine Bridge itself.

carsonbot commented 1 year ago

Thank you for this issue. There has not been a lot of activity here for a while. Has this been resolved?

carsonbot commented 1 year ago

Friendly ping? Should this still be open? I will close if I don't hear anything.

carsonbot commented 1 year ago

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!