Rework the file upload docs

javiereguiluz commented 4 months ago

We've merged #19807 and now the /controller page shows the nice #[MapUploadedFile] attribute.

This new feature is fantastic ... but I wonder if it's a good idea to show it in /controller.

This is one of the most critical chapters of Symfony Docs and part of the "Getting Started" series. So, I think that showing this could be a bit overwhelming for readers, mostly newcomers.

Also, we have this page too, which now looks weird and outdated: https://symfony.com/doc/current/controller/upload_file.html

So, this is what I propose:

Update controller/upload_file.rst entirely:
- Show the #[MapUploadedFile] attribute first
- Think if we should still show the previous way. If yes, let's do it at the bottom of the article and more concisely
Remove the #[MapUploadedFile] docs from controller.rst and only keep a tip mentioning it and linking to the doc about file uploads
These changes should only be made on 7.1 branch

What do you think?

MrYamous commented 3 months ago

Do you mind if I give a try on it ?

javiereguiluz commented 3 months ago

That would be awesome. But, before doing the actual work, an you please outline very briefly the changes you inten to make so others can help review the plan before doing the work? Thanks!

MrYamous commented 2 months ago

I thought about making the changes you described in the issue

javiereguiluz commented 2 months ago

@MrYamous I'm sorry for not having replied to you 🙏 OK, if you can, please try to contribute these changes. Thank you.

symfony / symfony-docs

Rework the file upload docs #19872