search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.15k stars 5.1k forks source link

[Mailer] Fixed and clarified custom Content-ID feature documentation #19946

Closed dakujem closed 1 month ago

dakujem commented 1 month ago

Addresses symfony/symfony #54162

The documentation is incorrect, as it shows calls to DataPart::setContentId with strings that are rejected by the method's implementation, because they do not contain a required @ character.

image

I also added a sentence clarifying that the actual Content-ID value will be ramdom-generated by Symfony when not using a custom Content-ID.

This feature has been added in v6.3 (according to the documentation) and the documentation is incorrect throughout versions 6.3, 6.4, 7.0, 7.1 and 7.2. I'm not sure how to distribute this PR to all other branches - should I create separate PRs for each?

carsonbot commented 1 month ago

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Could you update the PR base branch to target one of these branches instead? 5.4, 6.4, 7.0, 7.1, 7.2.

Cheers!

Carsonbot

dakujem commented 1 month ago

Okay, so I changed the base to 6.4 as 6.3 is no longer maintained.

xabbuh commented 1 month ago

I'm not sure how to distribute this PR to all other branches - should I create separate PRs for each?

There's no need for more than one PR. We always merge lower branches up into all maintained branches so that each change will eventually land in all still maintained doc versions.

javiereguiluz commented 1 month ago

Andrej, thanks a congrats on your first Symfony Docs contribution 🎉