search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.15k stars 5.1k forks source link

Add support for ACL auth in RedisAdapter, for 5.x branch #19955

Closed julienloizelet closed 1 month ago

julienloizelet commented 1 month ago

Symfony version(s) affected

5.x

Description

As I'm using symfony/cache:v5 (in a project that requires PHP 7.2, unfortunately), I'm facing this issue.

The Symfony 5 documentation states that it is possible to pass an user/password pair: 

redis[s]:[[user]:pass@]?[ip|host|socket[:port]][&params]

I understand, with this comment, that it has been considered as a new feature, and not a fix.

Should it be possible to add this fix also in the 5.x branch ?

If not, I guess the documentation should be updated for clarification.

How to reproduce

Same as https://github.com/symfony/symfony/issues/45305, but with symfony/cache:v5

Possible Solution

Use this patch : https://github.com/symfony/symfony/pull/45313/commits/722830d3c658c0652e95b4720da83b0f35091796#diff-38029e8e3e92a47fb8091876d3e8bc7fc61c2fc793cabf842ed933bf6985134c

Additional Context

No response

xabbuh commented 1 month ago

@julienloizelet Thanks for creating this bug report. We do indeed have to fix the documentation around this. That's why I have moved your issue in this repository.