search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.15k stars 5.1k forks source link

[ExpressionLanguage] Remove misleading warning #19960

Closed valepu closed 1 month ago

valepu commented 1 month ago

Fixes https://github.com/symfony/symfony-docs/issues/17978

The warning I am removing was created after https://github.com/symfony/symfony-docs/issues/8259 but the issue used an incorrect regex to show a potential problem which doesn't exist.

In my issue I show that it's not actually possible to inject control characters. I would still suggest for someone more involved in symfony development to investigate further, if the expression language is used in the security component this would need more than just a warning

javiereguiluz commented 1 month ago

I read again the issue #17978 and I think this proposal is correct.

But, let me ping smart folks like @nicolas-grekas @chalasr and @stof so they can double check this. Thanks!

javiereguiluz commented 1 month ago

Merged! (in 5.4 and up) Thanks @valepu and congrats on your first Symfony Docs contribution 🎉