search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.14k stars 5.1k forks source link

[TypeInfo] Better explain the `getBaseType()` method #20017

Closed javiereguiluz closed 3 days ago

javiereguiluz commented 1 week ago

Fixes #19843.

@mtarld if you have some time, please review this PR. Thanks a lot!

mtarld commented 1 week ago

@javiereguiluz, I just created the PR https://github.com/symfony/symfony/pull/57630 which rethinks and improves the component design and usage.

Therefore, I'd wait for this PR to be either merged or closed before going further :slightly_smiling_face:

javiereguiluz commented 1 week ago

Thanks Mathias ... but this PR only adds some short explanations about existing code examples. Even if your PR is accepted, it will merged in 7.2 branch, so I think it's OK to change this in 7.1 branch meanwhile.

javiereguiluz commented 3 days ago

Merged for the reasons explained above. If the changes proposed in the new code PR are merged, we'll keep updating these docs. Thanks.