search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.15k stars 5.1k forks source link

Remove Doctrine mappings YML from documentation #20050

Closed cosminsandu closed 1 month ago

cosminsandu commented 1 month ago

Since Doctrine 3.0 does not support YML configuration (see https://github.com/doctrine/DoctrineBundle/issues/1071 https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#bc-break-remove-yaml-mapping-drivers https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#deprecated-yaml-mapping-drivers ) Doctrine Configuration Reference (DoctrineBundle) documentation > Mapping Configuration > type should be updated to not contain yml format anymore.

please let me know if it is ok to remove the yml option from documentation.

cosminsandu commented 1 month ago

I think it should be a deprecated message - as in case of Annotations (on version 6.4 )

image

Please let me know on which Symfony version should I add this change.

xabbuh commented 1 month ago

We can do the change in the 5.4 branch as Doctrine ORM 3 is usable with Symfony 5.4.

cosminsandu commented 1 month ago

Looks like I need to add .. deprecated:: to a version of Symfony but in this case it is deprecated in ORM 3.0

Error: Please provide a numeric version behind ".. deprecated::" instead of "ORM 3.0"
Error: Please provide a numeric version behind ".. deprecated::" instead of "ORM 3.0"
Error: Please only provide ".. deprecated::" if the version is greater/equal "5.0"

https://github.com/symfony/symfony-docs/actions/runs/10006460548/job/27659228920?pr=20052

Please advice

javiereguiluz commented 1 month ago

Closing as fixed in #20052.