search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.15k stars 5.1k forks source link

[DomCrawler] fixes typo `Form::getFields()` -> `Form::getFiles()` #20077

Closed mvhirsch closed 1 month ago

mvhirsch commented 1 month ago

Looks like this method does not exist in Form: https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/DomCrawler/Form.php

I think it never did. Looking at v2.8 it does not exist, same's true for 3.4, 4.4, 5.4, 6.4, 7.0 ...

smnandre commented 1 month ago

Wonder if this was not supposed to be getFiles

mvhirsch commented 1 month ago

Wonder if this was not supposed to be getFiles

Maybe yes. Should I just rename instead of removing it @smnandre ?

xabbuh commented 1 month ago

renaming getFields() to getFiles() looks good to me

xabbuh commented 1 month ago

Good catch, thanks @mvhirsch.