search

symfony / symfony-docs

The Symfony documentation
https://symfony.com/doc
Other
2.16k stars 5.11k forks source link

Tilde is not rendered in doc #20215

Closed MrYamous closed 5 days ago

MrYamous commented 6 days ago

I noticed in the String documentation a tilde that doesn't appear (the space before 5,000)

Capture d’écran 2024-09-11 à 08 02 18

Do you think it can be a browser issue ? Tried with Chrome and Safari

I remembered this old PR #17624 for a similar issue. If it's about documentation rendering, for this case I think render it as code ~ is not fully appropriate

javiereguiluz commented 6 days ago

Thanks for reporting this. It looks like a bug, so I created a failing test in the Docs Builder tool that we use in Symfony Docs (see https://github.com/symfony-tools/docs-builder/pull/181).

Hopefully someone can investigate how to fix it. Thanks!

OskarStark commented 6 days ago

We could change it this way:

- of all emojis (~ 5000) ....
+ of all emojis (approx. 5000) ....

and see, if we can fix the parser somehow

OskarStark commented 5 days ago

Code-PR merged:

javiereguiluz commented 5 days ago

I'm closing this without merging because the error was solved thanks to the bug fix provided by @wouter in https://github.com/symfony-tools/docs-builder/pull/181

See the tilde character correctly rendered in production: https://symfony.com/doc/current/string.html#working-with-emojis

note: other Symfony Docs versions will be updated when the docs are fully rebuilt tonight.