search

symfony / symfony

The Symfony PHP framework
https://symfony.com
MIT License
29.52k stars 9.41k forks source link

[WebProfilerBundle] profiler ignores framework.validation.translation_domain: false setting #45848

Closed jennevdmeer closed 14 hours ago

jennevdmeer commented 2 years ago

Symfony version(s) affected

5.4

Description

When disabling validator translations according to https://symfony.com/doc/current/reference/configuration/framework.html#translation-domain by setting it to false.

config/validator.yaml

framework:
validation:
translation_domain: false

The profiler still shows them as being missing translation messages.

~How to reproduce~

~I have a simple repro (basic create project website/skeleton + form, templates, translator and validator) can be ran with php -S http://127.0.0.1:8000 -t public and then just clicking the submit button.~

~https://github.com/jennevdmeer/Symfony-WebProfilerBundle-ignores-framework.validation.translation_domain--false-setting~

Possible Solution

No response

Additional Context

Toolbar: image

Profiler: image

xabbuh commented 2 years ago

Reading the code I fail to see how this could have worked before (the docs were updated to account for false in symfony/symfony-docs#13371).

jennevdmeer commented 2 years ago

Reading the code I fail to see how this could have worked before (the docs were updated to account for false in symfony/symfony-docs#13371).

I'm confused as to what you are trying to say here. Are you talking about affected version? Because I just entered what I'm currently using in my project. It could have well been like this since it was introduced.

Another note on the issue me guessing it just replaces the translation domain to empty but still goes through the translation process. Just due to not having a name, no file is hit. Though I haven't tried just a .nl.yaml file.

carsonbot commented 1 year ago

Hey, thanks for your report! There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

carsonbot commented 1 year ago

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

jennevdmeer commented 1 year ago

Still relevant, nothing has changed afaik.

carsonbot commented 1 year ago

Hey, thanks for your report! There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

gndk commented 1 year ago

Still relevant, nothing has changed afaik.

carsonbot commented 7 months ago

Hey, thanks for your report! There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

carsonbot commented 6 months ago

Could I get a reply or should I close this?

jennevdmeer commented 6 months ago

I'm assuming nothing has changed.

carsonbot commented 2 weeks ago

Hey, thanks for your report! There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

carsonbot commented 5 days ago

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.