[Draft] [Translator] Add "by-domain" translation dumper - Githubissues

symfony / ux

Symfony UX initiative: a JavaScript ecosystem for Symfony

https://ux.symfony.com/

MIT License

781 stars 274 forks source link

[Draft] [Translator] Add "by-domain" translation dumper #1927

Open maelanleborgne opened 1 week ago

maelanleborgne commented 1 week ago

Q	A
Bug fix?	no
New feature?	yes
Issues	Fix #1225
License	MIT

Will follow #1930

Adds a new translation dumper to dump translations by domains in separated files. Theses files can be imported and registered with the new registerDomain(domain) js function, and accessed using the existing trans function by passing the translation key as a first argument.

TODO:

[ ] Add documentation
[ ] Add entry to changelog
[ ] Add better TS typing to the new functions/object
[ ] Add a TS declaration file for the new domains files ?

maelanleborgne commented 1 week ago

Hi, and thanks for your contribution! :)

I didn't look for everything, but isn't there too much things for a single PR? I see dump per domains, global domains filters, but also a new dumper for AssetMapper... is it too much?

Hi, I thought indeed about making two PRs : one for the filtering and another one for the 'per-domain' dump (which is what the AssetMapperDumper does, there won't be any change on the actual webpack-oriented behavior). I made it in one PR because it all came from the same issue, but I can still split the PR if need be.