search

symfony / ux

Symfony UX initiative: a JavaScript ecosystem for Symfony
https://ux.symfony.com/
MIT License
781 stars 274 forks source link

[Translator] Add configuration to filter dumped translations by domain #1930

Open maelanleborgne opened 1 week ago

maelanleborgne commented 1 week ago
Q A
Bug fix? no
New feature? yes
Issues Fix #1225
License MIT

Add two config entries included_domains and excluded_domains to filter which translation domains should be dumped. If included_domains is empty, it is not taken into account.

TODO:

smnandre commented 5 days ago

So were are we there ? :) Do you need help for something ? Is the doc ready ?

maelanleborgne commented 5 days ago

So were are we there ? :) Do you need help for something ? Is the doc ready ?

@smnandre Yes that should be it, the doc as well. I'm just not sure what version I should use in the changelog entry.

smnandre commented 5 days ago

2.19 no ?

smnandre commented 4 days ago

The failing test surprises me a bit ... @WebMamba any idea ? I feel we may have exposed more than we wanted

WebMamba commented 4 days ago

Looks like this is related to the PR: https://github.com/symfony/ux/pull/1940.

Hummm the test looks flaky. I don't think this is related to this PR though