symfony / ux

Symfony UX initiative: a JavaScript ecosystem for Symfony
https://ux.symfony.com/
MIT License
824 stars 298 forks source link

[Site] Use ux-icons (1/2) #1936

Closed smnandre closed 3 months ago

smnandre commented 3 months ago

First pass to switch from the old custom Icon component to ux-icons

Next step (once feature available on ux-icons)

smnandre commented 3 months ago

Let's ignore the cs-twig for now... that will require some work to fix the Twig CS Fixer "UX parser" i suppose

(poke @VincentLanglet if you have an idea to where i should start)

VincentLanglet commented 3 months ago

Let's ignore the cs-twig for now... that will require some work to fix the Twig CS Fixer "UX parser" i suppose

(poke @VincentLanglet if you have an idea to where i should start)

This is supposed to be fixed in 2.10.0 version https://github.com/VincentLanglet/Twig-CS-Fixer/releases/tag/2.10.0 I assume you need to bump the version https://github.com/symfony/ux/blob/2.x/ux.symfony.com/composer.lock#L11840-L11841

smnandre commented 3 months ago

Oh that's a great news :) Thank you !

smnandre commented 3 months ago

Remaining cs-twig failures are fixed in https://github.com/symfony/ux/pull/1935

kbond commented 3 months ago

Thanks Simon.