search

symfony / ux

Symfony UX initiative: a JavaScript ecosystem for Symfony
https://ux.symfony.com/
MIT License
824 stars 298 forks source link

Remove declare_strict type #1938

Closed WebMamba closed 3 months ago

WebMamba commented 3 months ago
Q A
Bug fix? no
New feature? no
Issues
License MIT

This PR removes the declare(strict_types=1);, to follow Symfony convention. See: https://github.com/Girgias/unify-typing-modes-rfc

I removed the declare(strict_types=1); only for the components and not for the website, in this PR for now.

cc: @nicolas-grekas

smnandre commented 3 months ago

I removed the declare(strict_types=1); only for the components and not for the website, in this PR for now.

Are there any strict_types in the website ?

smnandre commented 3 months ago

Is there a real need for a new release of TogglePassword, if it's just for this ?

(i mean, ok to change them, but should we release a version for this?)

WebMamba commented 3 months ago

Is there a real need for a new release of TogglePassword, if it's just for this?

I think this is fine, to not do a release for it

kbond commented 3 months ago

Thanks Matheo.