search

symfony / ux

Symfony UX initiative: a JavaScript ecosystem for Symfony
https://ux.symfony.com/
MIT License
833 stars 306 forks source link

Swup, main element animation #58

Closed disjfa closed 5 months ago

disjfa commented 3 years ago

The setup: I want to setup my site with my own id names, so i have set up the containers data-containers="#base #nav"

The problem: Now the swup animation does not work anymore. This is because the animation plugins also use an option on them to name the main element of the animation({{ mainElement: '#swup' }). See documentation.

https://swup.js.org/themes/fade-theme https://github.com/swup/fade-theme/blob/master/src/index.js#L11

The solution Add a data-main-element attribute so we can also setup the main elements for the animations.

optior commented 3 years ago

https://github.com/symfony/ux/pull/20 should solve this issue.

carsonbot commented 5 months ago

Thank you for this issue. There has not been a lot of activity here for a while. Has this been resolved?