Fixing reset assets trigger on sub-requests

symfony / webpack-encore-bundle

Symfony integration with Webpack Encore!

https://symfony.com/webpack-encore

MIT License

939 stars 83 forks source link

Fixing reset assets trigger on sub-requests #172

Closed TarikAmine closed 2 years ago

TarikAmine commented 2 years ago

1.14.0 is broken when a page contains sub requests, all the files managed by the package run twice. The event KernelEvents::FINISH_REQUEST should be handled for MainRequest only.

Sadly we are stuck at 1.13.2 until it's fixed

weaverryan commented 2 years ago

Thank you Tarik! This is a complex issue. Let's see if this can fix the bad behavior without introducing any other problems.