search

symfony / webpack-encore-bundle

Symfony integration with Webpack Encore!
https://symfony.com/webpack-encore
MIT License
933 stars 83 forks source link

Patch type declarations (Symfony 7.0) #224

Closed smnandre closed 10 months ago

smnandre commented 10 months ago

Not 100% sure of what i'm doing there..

I try to resolve this : https://github.com/symfony/ux/issues/1223

PHP Fatal error: Declaration of Symfony\WebpackEncoreBundle\CacheWarmer\EntrypointCacheWarmer::doWarmUp($cacheDir, Symfony\Component\Cache\Adapter\ArrayAdapter $arrayAdapter): bool must be compatible with Symfony\Bundle\FrameworkBundle\CacheWarmer\AbstractPhpFileCacheWarmer::doWarmUp(string $cacheDir, Symfony\Component\Cache\Adapter\ArrayAdapter $arrayAdapter, ?string $buildDir = null): bool in /home/runner/work/ux/ux/src/Turbo/vendor/symfony/webpack-encore-bundle/src/CacheWarmer/EntrypointCacheWarmer.php on line 27

And i follow that : https://symfony.com/blog/symfony-7-0-type-declarations

weaverryan commented 10 months ago

Thank you Simon! I was just coming to look into this - a few minor phpcs things, but I'll grab those.

smnandre commented 10 months ago

I asked some help (that i quickly and warmly got 🙇‍♂️ ) ... so thanks to them :) https://github.com/symfony/symfony/pull/52234