search

symfony / webpack-encore

A simple but powerful API for processing & compiling assets built around Webpack
https://symfony.com/doc/current/frontend.html
MIT License
2.22k stars 198 forks source link

Support eslint 9 #1267

Open garak opened 1 month ago

garak commented 1 month ago

Current output:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @symfony/webpack-encore@4.6.1
npm ERR! Found: eslint@9.1.1
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.1.1" from the root project
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm ERR!   node_modules/@eslint-community/eslint-utils
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from eslint@9.1.1
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional eslint@"^8.0.0" from @symfony/webpack-encore@4.6.1
npm ERR! node_modules/@symfony/webpack-encore
npm ERR!   dev @symfony/webpack-encore@"^4.6.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@8.57.0
npm ERR! node_modules/eslint
npm ERR!   peerOptional eslint@"^8.0.0" from @symfony/webpack-encore@4.6.1
npm ERR!   node_modules/@symfony/webpack-encore
npm ERR!     dev @symfony/webpack-encore@"^4.6.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
kumardeepakme commented 1 month ago

Yes, eslint 9 & postcss-loader 8

jMz1eujd20240501104525PMyCJsLh6C

rugbymauri commented 1 week ago

should be fixed in #1258

garak commented 1 week ago

should be fixed in #1258

But I don't see any change related to eslint there. Indeed, the proposed changes in the PR still use eslint 8.