Replace `assets-webpack-plugin` dependency by an internal plugin, to generate `entrypoints.json` file - Githubissues

symfony / webpack-encore

A simple but powerful API for processing & compiling assets built around Webpack

https://symfony.com/doc/current/frontend.html

MIT License

2.23k stars 199 forks source link

Replace `assets-webpack-plugin` dependency by an internal plugin, to generate `entrypoints.json` file #1342

Closed Kocal closed 1 month ago

Kocal commented 2 months ago

Q	A
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix #969
License	MIT

This PR replaces the https://github.com/ztoben/assets-webpack-plugin dependency with an internal plugin, this allows us:

to drop a dependency, and simplify the code (we don't need 10 ~options to generate the entrypoints.json for the WebpackEncoreBundle)
to not depend on https://github.com/waysact/webpack-subresource-integrity, which is necessary to use the integrity options of https://github.com/ztoben/assets-webpack-plugin
to generate the integrity data after files have been emitted

Things done in this PR:

Re-implement https://github.com/ztoben/assets-webpack-plugin functionality as closely as possible
Ensure tests pass without any modifications
Ensure the branch works like before on a real project (in dev/prod/dev-server, with or without integrity hashes)

Things not done in this PR:

https://github.com/symfony/webpack-encore/issues/1269 will have to wait for another PR, I don't wanted to fix that here