icon action font-awesome

symfony2admingenerator / AdmingeneratorGeneratorBundle

(old-legacy) Admingenerator for Symfony2, parse generator.yml files to build classes

http://symfony2admingenerator.org/

MIT License

360 stars 125 forks source link

icon action font-awesome #761

Closed alexbaron closed 10 years ago

alexbaron commented 10 years ago

hello,

I recently update from composer, and icone action from font-awesome doesn't work anymore. I correct it like this : In DeleteAction in Generator\Action folder

previously there is :

$this->setIcon('fa-times');

correction is :

$this->setIcon('fa fa-times');

montabou commented 10 years ago

It seems that I don't have that problem, is your repo up-to-date ?

ioleo commented 10 years ago

Recently, when the Twitter Bootstrap 3 style was introduced, we overlooked that the PR author changed font awesome icons into glyphicons (and also removed the hardcoded fa prefix).

This has been recently adressed (on 1.1 branch and dev-master branch) and should be working correctly now. Admingenerator uses, by default, font awesome 4.0, as it offers:

more icons than other sets
is completely free
is scallable/rotable/spinnable/stackable
shorter class names (more readable generator.ymls)

And by personal preference, I just think they look better :)