search

symfony2admingenerator / AdmingeneratorGeneratorBundle

(old-legacy) Admingenerator for Symfony2, parse generator.yml files to build classes
http://symfony2admingenerator.org/
MIT License
360 stars 125 forks source link

issue with error rendering and bootstrap 3 #783

Open jaugustin opened 10 years ago

jaugustin commented 10 years ago

Hi,

Error on forms are rendered incorrectly because of that commit https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/commit/02d8cb08cf7e9de80df40baaca498faa0c10f7b2#diff-460e769f42ed6a8f061c31d97916f203R60 which introduce this class form-control-feedback in a wrong way ;)

I think it should be something like this :

    <span class="glyphicon glyphicon-remove form-control-feedback"></span>
    <span class="help-block">
     .....
    </span>

And also add the class has-feedback next to has-error

I can provide a PR if needed

sescandell commented 10 years ago

Hi @jaugustin

I can provide a PR if needed

That would be perfect! Pull the request to branch 1.1 please

Thanks